[3.6.3] nullpointer on SqlPrecondition.class

[3.6.3] nullpointer on SqlPrecondition.class

in Liquibase Development • 8 months ago

There is a way of making a SQL statement in the precondition , which returns a NULL value.

the null value is handled incorrectly.

In Line 58 of SQL Precondition (ExecutorService) this returns a oResult of NULL

Null.toString(); issue.

try {
    Object oResult = ExecutorService.getInstance().getExecutor(database).queryForObject(new RawSqlStatement(this.getSql().replaceFirst(";$", "")), String.class);
    String result = oResult.toString();
    if (result == null) {
        throw new PreconditionFailedException("No rows returned from SQL Precondition", changeLog, this);
    } else {

Please fix in a newer version , this is a blocking change.

Caused by: java.lang.NullPointerException: null

at liquibase.precondition.core.SqlPrecondition.check(SqlPrecondition.java:51)

at liquibase.precondition.core.NotPrecondition.check(NotPrecondition.java:40)

at liquibase.precondition.core.AndPrecondition.check(AndPrecondition.java:45)

at liquibase.precondition.core.PreconditionContainer.check(PreconditionContainer.java:215)

at liquibase.changelog.ChangeSet.execute(ChangeSet.java:516)

... 58 common frames omitted

in version 3.5.5 this is just , why the change to do "oResult?" what does it add? for me it adds a nullpointer, Thanks in advance :) .

try {
    String result = (String)ExecutorService.getInstance().getExecutor(database).queryForObject(new RawSqlStatement(this.getSql().replaceFirst(";$", "")), String.class);
    if (result == null) {
        throw new PreconditionFailedException("No rows returned from SQL Precondition", changeLog, this);
    } else {
        String expectedResult = this.getExpectedResult();
        if (!expectedResult.equals(result)) {
            throw new PreconditionFailedException("SQL Precondition failed.  Expected '" + expectedResult + "' got '" + result + "'", changeLog, this);
        }
    }