Failure logs

General Discussion
1

I’m on version 2.0.1.

I do not want to print stack trace while failOnError is set to false. Therefore, is it OK to remove the SEVERE log in below code? Will this hide any away any other failures? I saw there are sufficient info level logging at ChangeSet.java line 340.

  1. class ExecuteStatementCallback implements StatementCallback {
                public Object doInStatement(Statement stmt) throws SQLException, DatabaseException {
                    for (String statement : applyVisitors(sql, sqlVisitors)) {
                        if (database instanceof OracleDatabase) {
                            statement = statement.replaceFirst("/\s*/\s*$", “”); //remove duplicated /'s
                        }

                        log.debug(“Executing EXECUTE database command: “+statement);
                        if (statement.contains(”?”)) {
                            stmt.setEscapeProcessing(false);
                        }
                        try {
                            stmt.execute(statement);
                        } catch (SQLException e) {
                            <span+statement, e);
                            throw e;
                        }
                    }
                    return null;
                }
Cheers,
Lahiru

2

Yes, that can be removed. 


Nathan