onFail with MARK_RAN (Liquibase 2.0)

General Discussion
1

I’m testing liquibase 2.0 RC2 (LQB-DEF-119).

I noticed that a changeset with a failing precondition and onFail set to MARK_RAN does not insert the corresponding record to DATABASECHANGELOG and next updateDatabase run executes/evalutates the changeset again.

In Liquibase 1.9.5 this changeset has been marked as ran in DATABASECHANGELOG.

2

I’ll take a look.  I created http://liquibase.jira.com/browse/CORE-531

Nathan

3

I’ve noticed that the resolution of bug CORE-531 is “Cannot Reproduce” but changesets with failed preconditions are still not inserted in DATABASECHANGELOG in my local tests of Liquibase 2.0 (LQB-DEF-134).

The attached changelog is executed via ANT and only entries for changeset 1 and 2 are inserted in DATABASECHANGELOG.

Following is logged during execution of ANT script:

    update: [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] INFO 07.01.10 08:36:liquibase: Successfully acquired change log lock [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateDatabase: Missing dependency org.hibernate.cfg.Configuration [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.database.core.HibernateGenericDialect: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] WARNING 07.01.10 08:36:liquibase: Could not configure extension class liquibase.snapshot.core.HibernateDatabaseSnapshotGenerator: Missing dependency org.hibernate.dialect.Dialect [updateDatabase] INFO 07.01.10 08:36:liquibase: Reading from LIQUIBASE.DATABASECHANGELOG [updateDatabase] INFO 07.01.10 08:36:liquibase: ChangeSet 3.3.0.01/2009-09-18-5062.xml::1::user ran successfully in 0ms [updateDatabase] INFO 07.01.10 08:36:liquibase: ChangeSet 3.3.0.01/2009-09-18-5062.xml::2::user ran successfully in 0ms [updateDatabase] INFO 07.01.10 08:36:liquibase: Marking ChangeSet: 3.3.0.01/2009-09-18-5062.xml::3::user::(Checksum: 2:c37bc10575fc36d1b09257c3b6de4dc2) ran despite precondition failure: [updateDatabase]          C:/Data/SDP/test/liquibase/changelogs/master.xml : Not precondition failed [updateDatabase] INFO 07.01.10 08:36:liquibase: Marking ChangeSet: 3.3.0.01/2009-09-18-5062.xml::4::user::(Checksum: 2:c37bc10575fc36d1b09257c3b6de4dc2) ran despite precondition failure: [updateDatabase]          C:/Data/SDP/test/liquibase/changelogs/master.xml : Table LIQUIBASE.NOEXISTINGTABLE does not exist [updateDatabase] INFO 07.01.10 08:36:liquibase: Successfully released change log lock BUILD SUCCESSFUL
4

Thanks for the testcase, I reopened the issue

Nathan