H2 Remark support for columns and tables.

Liquibase Development
1

Hello,


I stumbled across a lack of support for remarks (comments) when dealing with H2 databases.  H2 supports the SQL standard COMMENT ON… syntax.  I had a look in the source code and it seemed like low hanging fruit, so I sucessfully applied the following patch:

  2. ---
  3.  .../java/liquibase/sqlgenerator/core/SetColumnRemarksGenerator.java   | 4 +++-
  4.  .../java/liquibase/sqlgenerator/core/SetTableRemarksGenerator.java    | 3 ++-
  5.  2 files changed, 5 insertions(+), 2 deletions(-)

  7. diff --git a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/SetColumnRemarksGenerator.java b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/SetColumnRemarksGenerator.java
  8. index ec76acf..3661150 100644
  9. --- a/liquibase-core/src/main/java/liquibase/sqlgenerator/core/SetColumnRemarksGenerator.java
  10. +++ b/liquibase-core/src/main/java/liquibase/sqlgenerator/core/SetColumnRemarksGenerator.java
  11. @@ -4,6 +4,7 @@ import liquibase.database.Database;
  12.  import liquibase.database.core.DB2Database;
  13.  import liquibase.database.core.OracleDatabase;
  14.  import liquibase.database.core.PostgresDatabase;
  15. +import liquibase.database.core.H2Database;
  16.  import liquibase.exception.ValidationErrors;
  17.  import liquibase.sql.Sql;
  18.  import liquibase.sql.UnparsedSql;
  19. @@ -20,7 +21,8 @@ public class SetColumnRemarksGenerator extends AbstractSqlGenerator<SetColumnRem
  20.  
  21.   @Override
  22. -- 
... that seemed to do the trick for me.  I don't really have the time to figure out what side effects this might have, nor did I write any tests.  If the change is not problematic, I would be thankful if it made its way into a future release so I can avoid using my fork.


Thanks, 

Sam