NPE in liquibase-hibernate TableSnapshotGenerator during snapshotObject primaryKey definition

General Discussion
1

That is a known bug. It is fixed in the repository now and will probably have a new build containing it next week.


Nathan

2

Hi,


I’m slowly working my way though integrating Liquibase, Hibernate, Spring and the Maven and I’ve stumbled onto what I believe is a bug in the liquibase-hibernate extension in the TableSnapshotGenerator class. It looks like that when iterating through the columns we attempt to build the collection of primary keys. The problem is that the first time through we attempt to set the name of the PrimaryKey to the table.getPrimaryKey.getName() (line 82) which has not be set yet. This results in the crowd favorite NPE. I’m not exactly certain the intent here is I thought I’d bring it to the attention of folks. Stack trace and snippet follow:






  2. INFO 2/28/14 1:53 PM:liquibase-hibernate: Found table summary
  3. INFO 2/28/14 1:53 PM:liquibase-hibernate: Found column id bigint
  4. [INFO] ------------------------------------------------------------------------
  5. [INFO] BUILD FAILURE
  6. [INFO] ------------------------------------------------------------------------
  7. [INFO] Total time: 6.794s
  8. [INFO] Finished at: Fri Feb 28 13:53:59 PST 2014
  9. [INFO] Final Memory: 14M/313M
  10. [INFO] ------------------------------------------------------------------------
  11. [ERROR] Failed to execute goal org.liquibase:liquibase-maven-plugin:3.1.1:diff (default-cli) on project nigg_fair: Execution default-cli of goal org.liquibase:liquibase-maven-plugin:3.1.1:diff failed. NullPointerException -> [Help 1]
  12. org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.liquibase:liquibase-maven-plugin:3.1.1:diff (default-cli) on project my_project: Execution default-cli of goal org.liquibase:liquibase-maven-plugin:3.1.1:diff failed.
  15.     protected DatabaseObject snapshotObject(DatabaseObject example, DatabaseSnapshot snapshot) throws DatabaseException, InvalidExampleException {
  16.  ...
  17. // line 69
  19.             org.hibernate.mapping.PrimaryKey hibernatePrimaryKey = hibernateTable.getPrimaryKey();
  20.             if (hibernatePrimaryKey != null) {
  21.                 boolean isPrimaryKeyColumn = false;
  22.                 for (org.hibernate.mapping.Column pkColumn : (List) hibernatePrimaryKey.getColumns()) {
  23.                     if (pkColumn.getName().equals(hibernateColumn.getName())) {
  24.                         isPrimaryKeyColumn = true;
  25.                         break;
  26.                     }
  27.                 }

  29.                 if (isPrimaryKeyColumn) {
  30.                     if (primaryKey == null) {
  31.                         primaryKey = new PrimaryKey();
  32. // line 82 - ?
  33.                         primaryKey.setName(table.getPrimaryKey().getName());
  34.                     }
  35.                     primaryKey.addColumnName(pkColumnPosition++, column.getName());

  37.                     Value value = hibernateColumn.getValue();