PostgresTypeConverter does not override getNumberType

Liquibase Development
1

I noticed that the PostgresTypeConverter does not override the method getNumberType.  The default implementation, as provided by the AbstractTypeConverter, is to return a new NumberType. The constructor for NumberType calls the super-constructor with a dataTypeName parameter of “NUMBER”.

Now Postgres does not know a NUMBER datatype, but it does know NUMERIC.

So I have the following question: why is the getNumberType method in PostgresTypeConverter not overridden as:

    @Override public NumberType getNumberType() {     return new NumberType("NUMERIC"); }
2

Great! Thanks for the effort.

Daan

3

It should be.  I committed that change.  Thanks for pointing it out.

Nathan

4

As a turnaround PGSql recognize DECIMAL(X,Y) as a valid Datatype 


HTH. 

Greg

5

One can use DECIMAL Instead of NUMBER, This one is correctly handled.

Btw , it seems that NUMBER is not a SQL 92 datatype …


Greg