Looks like you did everything correctly to me. I know Nathan is pretty busy, so it might be a few days before this gets merged, etc.
You will not need to clone again to do more work. You will need to make sure you are up-to-date before you push changes, so you will need to git pull.
Steve Donie
Principal Software Engineer
Datical, Inc. http://www.datical.com/
Hi, all.
I've followed the guidelines on the Liquibase DEV page as best I can. Can someone cross check that I've done things right? Here's what I did:
1) Registered as a user with Atlassian Cloud so I could create a Jira issue.
2) Created Jira issue CORE-2262
3) Forked the Liquibase repo at https://github.com/liquibase/liquibase, creating https://github.com/bsandiford/liquibase
4) Set my new repo default branch to 3.3.x to match where I'd like the fix made in Liquibase.
5) Checked out from my new repo, fixed the problem, committed and pushed back to my repo. Commit message includes the Jira number, summary, and what I fixed.
6) Created a pull request, and put a comment on the Jira issue so that it references the pull request (#366)
7) Waiting for someone to look at the pull request / merge back (hopefully!) / update the Jira.
One additional question. I have another bug fix I'd like to make. Do I need to clone Liquibase again, or can I just continue in my own repository?
Thanks!
Bob (newbie) Sandiford.
Thanks, Steve!
OK - turns out I missed a step. For multiple pull requests from the same fork, each change should be checked into a separate branch of the forked code. Otherwise, subsequent checkins to the base of the fork just end up being added to the first pull request.
So, I'm branching my repo for each separate change, and I'll do a pull request for each branch - that will keep them all separate.
